fix: trim whitespace when parsing numeric properties #6283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: if the value parses after trimming, then it would likely be the one the user wants. Currently, a trailing whitespace in UI is hard to notice, and it breaks test execution. For instance ThreadGroup.threadNum becomes 0 without any warning, and it invalidates test results.
|
LGTM |
|
This has already been committed in 289b3d1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If the value parses after trimming, then it would likely be the one the user wants.
Currently, a trailing whitespace in UI is hard to notice, and it breaks test execution. For instance
ThreadGroup.threadNumbecomes0without any warning, and it invalidates test results.