Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#124 LoggingEvent.Level not nullable #137

Conversation

FreeAndNil
Copy link
Contributor

#124 LoggingEvent.Level not nullable
@erikmav what do you think about this approach?

@FreeAndNil FreeAndNil changed the base branch from master to Feature/111-Dropping-support-for-older-runtimes March 28, 2024 18:44
@erikmav
Copy link
Contributor

erikmav commented Mar 28, 2024

In the 2.x codebase a null level was handled as an allowed option, and some formatters use default behaviors on a null value (search for level is null across the codebase). IOW this is probably a back compat problem where we might break people. Maybe that's OK in v3... which means we need if (level is null) { throw new ArgumentNullException(nameof(level)); } anywhere we're receiving a level from the user.

@FreeAndNil FreeAndNil force-pushed the Feature/111-Dropping-support-for-older-runtimes branch from 7e93b50 to 6d23e81 Compare April 3, 2024 20:33
@FreeAndNil FreeAndNil force-pushed the Feature/133-nullable-Level branch from 191705e to bf9a21d Compare April 4, 2024 07:11
@FreeAndNil FreeAndNil closed this Apr 4, 2024
@FreeAndNil FreeAndNil deleted the Feature/133-nullable-Level branch April 4, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants