-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBUILDCACHE-74] Clean local cache for any artifact #110
[MBUILDCACHE-74] Clean local cache for any artifact #110
Conversation
50b4b74
to
15baafb
Compare
src/test/projects/mbuildcache-74-clean-cache-any-artifact/pom.xml
Outdated
Show resolved
Hide resolved
src/test/projects/mbuildcache-74-clean-cache-any-artifact/.mvn/extensions.xml
Outdated
Show resolved
Hide resolved
15baafb
to
b6e9ff0
Compare
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java
Outdated
Show resolved
Hide resolved
Not just the ones which have a package phase. Otherwise the cached builds will be kept forever.
b6e9ff0
to
532a24d
Compare
Oops, I didn't pay attention and force pushed a local change to the root pom.xml which helps vscode to actually recognize the generated sources folder for the mdo generated models. This now landed on master. I am very sorry for this mistake! Please let me know if you want to keep it. It shouldn't hurt the build, but it's still IDE specific. (vscode uses Eclipse' m2e backend which needs some help with the classpath extension; dunno specifically if this change also helps Eclipse users as well) |
@mweirauch no worries. My bad I didn’t check the PR correctly with last commit. |
Signed-off-by: Olivier Lamy <[email protected]>
@mweirauch done with #114 |
Signed-off-by: Olivier Lamy <[email protected]>
This MR cleans up any cached local build, no matter if the module/project in question has a package phase.
I noticed stale cache entries for our parent POM in the local build cache, which were not cleaned up.
--
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MBUILDCACHE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.