-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements #634
Conversation
Not needed: if (item && item.type && The original behavior is somewhat different anyway... i just changed it somehow for the new code to cover more elements (aka every element) Either way we theoretically could unify the behavior for all branches, the old code and new code that would be feasible, if wanted, given this is a non standard behavior we are free here to do whatever we want! |
@werpu What do you recommend here? |
Yes the original code only allows submits and buttons to be appended as issuing item, hence I said the problem does not affect the old code, I guess we have to replicate the 4.x behavior into the old code might make sense to have a unified behavior, I will prepare something the next few days! |
@werpu Any updates? Thank you |
I would like to merge this if possible soon in order to get new 2.3 3.0 ... etc releases out. |
Hi I will work on the issue today! |
I have issued a working code for 3.0, please see: my integration tests pass, it is basically a backport from 4.0 Please give it a shot and then we can merge if it is ok, this one can now be seen as for 3.x! I also will issue a bunch of merge requests for the lower versioned branches so that we keep the code in sync, the build for 2.3-next seems to be broken (I have issued one there already) |
Closing in favor of #638. |
https://issues.apache.org/jira/browse/MYFACES-4606