Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYFACES-4708: Quarkus 3.8.2 #832

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

melloware
Copy link
Contributor

No description provided.

@melloware melloware requested a review from volosied January 13, 2025 20:32
@volosied
Copy link
Contributor

Still failing for me:

[ERROR] myfaces/extensions/quarkus/runtime/src/main/java/org/apache/myfaces/core/extensions/quarkus/runtime/scopes/QuarkusClientWindowScopedContext.java:[21,22] cannot access io.quarkus.arc.InjectableContext
[ERROR]   bad class file: .m2/repository/io/quarkus/arc/arc/3.8.2/arc-3.8.2.jar(/io/quarkus/arc/InjectableContext.class)
[ERROR]     class file has wrong version 61.0, should be 55.0

Looks like Java 17 was introduced in 3.7: https://quarkus.io/blog/java-17/

Alternatively, I wonder if you can set a higher java level for the quarkus sub-projects? However, that means Faces standalone needs JDK 11, but with Quarkus will require Java 17.

@melloware
Copy link
Contributor Author

ahhh damn.

@melloware
Copy link
Contributor Author

I bumped it to 17 but i have no idea if thta will work just for the extension?

@volosied
Copy link
Contributor

facepalm You're right -- my suggestion was bad.... since JDK 11 doesn't know about 17.

Any chance you can use an older version? I verified that 3.6.9 still uses Java 11:

javap -v  io/quarkus/arc/runtime/devconsole/InvocationsMonitor.class  | grep major
  major version: 55

Can we recommend any users who need quarkus 3.7 or higher use Faces 4.1 instead? It's a minor release, so it shouldn't pose any migration issues.

@volosied
Copy link
Contributor

Or we change the required JDK to Java 17 for 4.0 -- target Java 11 for the API / IMPL but quarkus for 17. I think this would need some community discussion.

Alternatively, we just keep 3.15.1, if possible? I don't know too much about these different quarkus libraries, but we don't change the compilation level for MyFaces.

@melloware
Copy link
Contributor Author

yep let me back up to 3.6.9 no problem. 4.0 should stay on 11 that is my bad!

@melloware
Copy link
Contributor Author

I reverted back to 3.2.9 which is the last LTS release before 3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants