Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14155 Improve ObjectMapper handling in TokenParserFactory #9648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-14155 Improves handling of the Jackson ObjectMapper in the TokenParserFactory interface and associated implementations. Improvements include refactoring the interface definition to remove configuration variables so that ObjectMapper and JsonFactory instances can be reused.

The refactored approach applies to JSON and YAML Record Readers as well as the Record Transform Proxy for Python Record Processors. The revised implementation creates instances of ObjectMapper with configured Stream Read Constraints on Controller Service enabling. With thread safety provided in JsonFactory and ObjectMapper, reusing these objects improves performance for repeated processing operations.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Refactored TokenParserFactory interface to accept InputStream without configuration parameters
- Avoided unnecessary ObjectMapper creation in JsonParserFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant