NIFI-14068 Fix Domain Name Handling for SFTP Proxy Access #9649
+121
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14068 Corrects the behavior of SFTP processors when configured for proxy access using a DNS name.
The current implementation of the SSHJ
SSHClient
always attempts to resolve DNS names to IP addresses when constructing anInetSocketAddress
for the socket connection. This behavior is not ideal when connecting through a proxy server because NiFi may not be able to resolve the DNS address and should rely on the proxy server to perform DNS resolution.The revised implementation introduces an extension of
SSHClient
that overrides themakeInetSocketAddress
method to return an unresolved address when the client is configured with a Proxy Socket Factory. The unresolved status instructs HTTP and SOCKS proxy socket clients to send a DNS address instead of a resolved IP address.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation