[fix] Fix comments

apache · Sep 23, 2024 · 5694e63 · 5694e63
1 parent efdd226
commit 5694e63
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java b/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java
@@ -214,7 +214,6 @@ public List<CommitMessage> prepareCommit(boolean waitCompaction, long commitIden
                 result.add(committable);
 
                 if (committable.isEmpty()) {
-
                     if (writerCleanChecker.apply(writerContainer)) {
                         // Clear writer if no update, and if its latest modification has committed.
                         //
@@ -246,6 +245,10 @@ public List<CommitMessage> prepareCommit(boolean waitCompaction, long commitIden
         return result;
     }
 
+    // This abstract function returns a whole function (instead of just a boolean value),
+    // because we do not want to introduce `commitUser` into this base class.
+    //
+    // For writers with no conflicts, `commitUser` might be some random value.
     protected abstract Function<WriterContainer<T>, Boolean> createWriterCleanChecker();
 
     protected static <T>

diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/AppendOnlyFileStoreWrite.java b/paimon-core/src/main/java/org/apache/paimon/operation/AppendOnlyFileStoreWrite.java
@@ -139,7 +139,7 @@ protected abstract CompactManager getCompactManager(
             int bucket,
             List<DataFileMeta> restoredFiles,
             ExecutorService compactExecutor,
-            @javax.annotation.Nullable DeletionVectorsMaintainer dvMaintainer);
+            @Nullable DeletionVectorsMaintainer dvMaintainer);
 
     public List<DataFileMeta> compactRewrite(
             BinaryRow partition,

diff --git a/...n-core/src/main/java/org/apache/paimon/operation/AppendOnlyFixedBucketFileStoreWrite.java b/...n-core/src/main/java/org/apache/paimon/operation/AppendOnlyFixedBucketFileStoreWrite.java
@@ -75,7 +75,7 @@ protected CompactManager getCompactManager(
             int bucket,
             List<DataFileMeta> restoredFiles,
             ExecutorService compactExecutor,
-            @javax.annotation.Nullable DeletionVectorsMaintainer dvMaintainer) {
+            @Nullable DeletionVectorsMaintainer dvMaintainer) {
         if (options.writeOnly()) {
             return new NoopCompactManager();
         } else {

diff --git a/...imon-flink-common/src/main/java/org/apache/paimon/flink/sink/NoopStoreSinkWriteState.java b/...imon-flink-common/src/main/java/org/apache/paimon/flink/sink/NoopStoreSinkWriteState.java
@@ -20,7 +20,6 @@
 
 import javax.annotation.Nullable;
 
-import java.util.Collections;
 import java.util.List;
 
 /**
@@ -42,11 +41,13 @@ public StateValueFilter stateValueFilter() {
 
     @Override
     public @Nullable List<StateValue> get(String tableName, String key) {
-        return Collections.emptyList();
+        throw new UnsupportedOperationException();
     }
 
     @Override
-    public void put(String tableName, String key, List<StateValue> stateValues) {}
+    public void put(String tableName, String key, List<StateValue> stateValues) {
+        throw new UnsupportedOperationException();
+    }
 
     @Override
     public void snapshotState() throws Exception {}

diff --git a/...nk/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/TableWriteOperator.java b/...nk/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/TableWriteOperator.java
@@ -38,7 +38,7 @@ public abstract class TableWriteOperator<IN> extends PrepareCommitOperator<IN, C
     private final StoreSinkWrite.Provider storeSinkWriteProvider;
     private final String initialCommitUser;
 
-    protected transient StoreSinkWriteState state;
+    private transient StoreSinkWriteState state;
     protected transient StoreSinkWrite write;
 
     public TableWriteOperator(

diff --git a/...link-common/src/test/java/org/apache/paimon/flink/UnawareBucketAppendOnlyTableITCase.java b/...link-common/src/test/java/org/apache/paimon/flink/UnawareBucketAppendOnlyTableITCase.java
@@ -18,9 +18,6 @@
 
 package org.apache.paimon.flink;
 
-import org.apache.flink.runtime.state.FunctionInitializationContext;
-import org.apache.flink.runtime.state.FunctionSnapshotContext;
-import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction;
 import org.apache.paimon.Snapshot;
 import org.apache.paimon.data.InternalRow;
 import org.apache.paimon.fs.Path;