Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Introduce ClearConsumersProcedure to clear consumers #4893

Merged

Conversation

chenxinwei
Copy link
Contributor

Change-Id: I05d02f5c48c82d633436260f1ca5f6d0e9ddfcc4

Purpose

Sometimes,we may want to modify the consumerId in a Flink task.However, if we do not delete other consumers that are not actually used at this time, the expired data will not be effectively cleaned up.So I want to support Support clearing all consumers execept specified consumer in the consumer directory.

Linked issue: close #4599

I will introduce the ClearConsumersProcedure to support clearing unspecified consumers, clearing specified consumers, and clearing all consumers in a table.

Tests

Add UT in ConsumerActionITCase.

API and Format

Documentation

@chenxinwei chenxinwei requested a review from JingsongLi January 13, 2025 08:48
@xiangyuf
Copy link
Contributor

@chenxinwei Can you add more information about this procedure in procedures.md?

@chenxinwei chenxinwei force-pushed the master_add_clear_consumers_procedure branch from a275241 to 727ba2c Compare January 19, 2025 07:24
@chenxinwei
Copy link
Contributor Author

chenxinwei commented Jan 20, 2025

@chenxinwei Can you add more information about this procedure in procedures.md?
Fixed

@chenxinwei chenxinwei closed this Jan 20, 2025
@chenxinwei chenxinwei reopened this Jan 20, 2025
@chenxinwei chenxinwei requested a review from xiangyuf January 20, 2025 12:53
@chenxinwei chenxinwei force-pushed the master_add_clear_consumers_procedure branch from fac3cf7 to 9fbd023 Compare February 5, 2025 05:03
@chenxinwei chenxinwei requested a review from xiangyuf February 5, 2025 05:40
chenxinwei and others added 5 commits February 5, 2025 20:33
Change-Id: I05d02f5c48c82d633436260f1ca5f6d0e9ddfcc4
Change-Id: I9e6abe5e52c5c35b263e0a709ceb7c00bf3f8a30
Change-Id: I66d3d6a774bcaa20a7c473b053490bfe614a7c95
Change-Id: Id3912c1c2c90a7beaf41fba1d9c35f162ad6d605
Change-Id: I2b94e9f7519b36cbd4f2eed8c82a84809ad8643b
Change-Id: I2bbdfb3e81396b0eae0bc7b33449ae46cb8a93ef
Change-Id: I0064aa87a79b7e477d64e8b49fc2f58d04717359
@chenxinwei chenxinwei force-pushed the master_add_clear_consumers_procedure branch from 6e0613e to 257bb7a Compare February 5, 2025 12:36
@xiangyuf
Copy link
Contributor

xiangyuf commented Feb 5, 2025

LGTM, thx for ur work. cc: @wwj6591812 @JingsongLi

Change-Id: Iab746c53db5c0bdaf4b2cacd80ea67cd99342f5a
@chenxinwei chenxinwei requested a review from xiangyuf February 10, 2025 03:43
Copy link
Contributor

@xiangyuf xiangyuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chenxinwei
Copy link
Contributor Author

chenxinwei commented Feb 10, 2025

@wwj6591812 @JingsongLi PTAL, thanks!

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @chenxinwei @xiangyuf

@JingsongLi JingsongLi merged commit 9a5bf99 into apache:master Feb 12, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support clearing all consumers execept specified consumer in the consumer directory
5 participants