-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Introduce ClearConsumersProcedure to clear consumers #4893
[core] Introduce ClearConsumersProcedure to clear consumers #4893
Conversation
Rebase master
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
@chenxinwei Can you add more information about this procedure in procedures.md? |
...imon-flink-1.18/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/consumer/ConsumerManager.java
Outdated
Show resolved
Hide resolved
...imon-flink-1.18/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
...imon-flink-1.18/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
a275241
to
727ba2c
Compare
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
|
paimon-core/src/main/java/org/apache/paimon/consumer/ConsumerManager.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/consumer/ConsumerManager.java
Outdated
Show resolved
Hide resolved
...on-spark-common/src/main/java/org/apache/paimon/spark/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
fac3cf7
to
9fbd023
Compare
...nk/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/ClearConsumerAction.java
Outdated
Show resolved
Hide resolved
Rebase master
Change-Id: I05d02f5c48c82d633436260f1ca5f6d0e9ddfcc4
Change-Id: I9e6abe5e52c5c35b263e0a709ceb7c00bf3f8a30
Change-Id: I66d3d6a774bcaa20a7c473b053490bfe614a7c95
Change-Id: Id3912c1c2c90a7beaf41fba1d9c35f162ad6d605
Change-Id: I2b94e9f7519b36cbd4f2eed8c82a84809ad8643b
Change-Id: I2bbdfb3e81396b0eae0bc7b33449ae46cb8a93ef
Change-Id: I0064aa87a79b7e477d64e8b49fc2f58d04717359
6e0613e
to
257bb7a
Compare
LGTM, thx for ur work. cc: @wwj6591812 @JingsongLi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@wwj6591812 @JingsongLi PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @chenxinwei @xiangyuf
Change-Id: I05d02f5c48c82d633436260f1ca5f6d0e9ddfcc4
Purpose
Sometimes,we may want to modify the consumerId in a Flink task.However, if we do not delete other consumers that are not actually used at this time, the expired data will not be effectively cleaned up.So I want to support Support clearing all consumers execept specified consumer in the consumer directory.
Linked issue: close #4599
I will introduce the ClearConsumersProcedure to support clearing unspecified consumers, clearing specified consumers, and clearing all consumers in a table.
Tests
Add UT in ConsumerActionITCase.
API and Format
Documentation