[flink] Remove scan.push-down support which should be supported by Flink #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Sep 22, 2024
| import java.util.List; | ||
|
|
||
| /** A {@link BaseDataTableSource} for Flink 1.15. */ | ||
| public class DataTableSource extends BaseDataTableSource { |
There was a problem hiding this comment.
It is a BaseDataTableSource, ref to self is meaningless.
| * org.apache.flink.connector.base.source.hybrid.HybridSource} of {@code | ||
| * LogHybridSourceFactory.FlinkHybridFirstSource} and kafka log source created by {@link | ||
| * LogSourceProvider}. | ||
| * A {@link BaseDataTableSource} implements {@link SupportsStatisticReport} and {@link |
There was a problem hiding this comment.
Change BaseDataTableSource to DataTableSource?
There was a problem hiding this comment.
It is a BaseDataTableSource, ref to self is meaningless.
| @@ -116,12 +116,6 @@ | |||
| <td>Integer</td> | |||
| <td>Define a custom parallelism for the scan source. By default, if this option is not defined, the planner will derive the parallelism for each statement individually by also considering the global configuration. If user enable the scan.infer-parallelism, the planner will derive the parallelism by inferred parallelism.</td> | |||
| </tr> | |||
| <tr> | |||
There was a problem hiding this comment.
Cut scan.push-down in ContinuousFileStoreITCase.java.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The scan.push-down makes source codes very complicate, it should be supported by Flink SQL instead of Paimon.
In this PR, we remove it, if the user have requirement, he should ask Flink community to support this.
Tests
API and Format
Documentation