write trailers directly into headers on failure

apache · Oct 23, 2024 · 88dc99d · 88dc99d
1 parent f5bbf39
commit 88dc99d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/runtime/src/main/scala/org/apache/pekko/grpc/internal/GrpcEntityHelpers.scala b/runtime/src/main/scala/org/apache/pekko/grpc/internal/GrpcEntityHelpers.scala
@@ -74,7 +74,10 @@ object GrpcEntityHelpers {
     TrailerFrame(trailers = statusHeaders(status))
 
   def trailer(status: Status, metadata: Metadata): TrailerFrame =
-    TrailerFrame(trailers = statusHeaders(status) ++ metadataHeaders(metadata))
+    TrailerFrame(trailers = trailers(status, metadata))
+
+  def trailers(status: Status, metadata: Metadata): List[HttpHeader] =
+    statusHeaders(status) ++ metadataHeaders(metadata)
 
   def statusHeaders(status: Status): List[HttpHeader] =
     List(headers.`Status`(status.getCode.value.toString)) ++ Option(status.getDescription).map(d =>

diff --git a/runtime/src/main/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpers.scala b/runtime/src/main/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpers.scala
@@ -107,6 +107,12 @@ object GrpcResponseHelpers {
       entity = HttpEntity.Chunked(writer.contentType, entity))
   }
 
-  def status(trailer: Trailers)(implicit writer: GrpcProtocolWriter): HttpResponse =
-    response(Source.single(writer.encodeFrame(GrpcEntityHelpers.trailer(trailer.status, trailer.metadata))))
+  def status(trailer: Trailers)(implicit writer: GrpcProtocolWriter): HttpResponse = {
+    HttpResponse(
+      headers =
+        headers.`Message-Encoding`(writer.messageEncoding.name) ::
+        GrpcEntityHelpers.trailers(trailer.status, trailer.metadata),
+      entity = HttpEntity.empty(writer.contentType)
+    )
+  }
 }