[HELM]: Publish Helm 0.3.0 #14169
[HELM]: Publish Helm 0.3.0 #14169
Conversation
helm/index.yaml
Outdated
| urls: | ||
| - pinot-0.2.9.tgz |
There was a problem hiding this comment.
Please only modify the 0.3.0 section, don't change the older ones.
There was a problem hiding this comment.
Gotcha, sorry about that. Should be fixed now except a trailing EOL on the index.yaml file. Will this be ok?
helm/index.yaml
Outdated
| name: pinot | ||
| sources: | ||
| - https://github.com/apache/pinot/tree/master/helm | ||
| - https://github.com/apache/pinot/tree/master/helm |
There was a problem hiding this comment.
This should be https://github.com/apache/pinot/tree/master/helm; please make a change.
helm/index.yaml
Outdated
| version: 0.2.9 | ||
| - apiVersion: v1 | ||
| appVersion: 1.0.0 | ||
| created: "2024-02-22T11:12:34.734773+08:00" |
There was a problem hiding this comment.
Only the newer generated version created should have the current date; for all other versions, it should be whatever is in the file.
helm/index.yaml
Outdated
| dependencies: | ||
| - condition: pinot.zookeeper.enabled,zookeeper.enabled | ||
| name: zookeeper | ||
| repository: https://charts.helm.sh/incubator | ||
| repository: https://kubernetes-charts-incubator.storage.googleapis.com/ |
There was a problem hiding this comment.
@xiangfu0, is it correct?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14169 +/- ##
============================================
+ Coverage 61.75% 63.92% +2.17%
- Complexity 207 1532 +1325
============================================
Files 2436 2621 +185
Lines 133233 144036 +10803
Branches 20636 22030 +1394
============================================
+ Hits 82274 92078 +9804
- Misses 44911 45167 +256
- Partials 6048 6791 +743
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue related to the new Helm update.
cc: @abhioncbr @xiangfu0