Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom params to AggInfo so that series builders can use it. #14173

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

raghavyadav01
Copy link
Contributor

  • Adding custom params to AggInfo so that series builders can use it.
  • Unit test to validate the changes.
  • I have verified the changes work manually as well with quickstart.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (59551e4) to head (79d4f2c).
Report is 1142 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/java/org/apache/pinot/tsdb/spi/AggInfo.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14173      +/-   ##
============================================
+ Coverage     61.75%   63.84%   +2.09%     
- Complexity      207     1531    +1324     
============================================
  Files          2436     2621     +185     
  Lines        133233   144051   +10818     
  Branches      20636    22030    +1394     
============================================
+ Hits          82274    91965    +9691     
- Misses        44911    45315     +404     
- Partials       6048     6771     +723     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.81% <75.00%> (+2.10%) ⬆️
java-21 63.71% <75.00%> (+2.08%) ⬆️
skip-bytebuffers-false 63.82% <75.00%> (+2.07%) ⬆️
skip-bytebuffers-true 63.69% <75.00%> (+35.96%) ⬆️
temurin 63.84% <75.00%> (+2.09%) ⬆️
unittests 63.83% <75.00%> (+2.09%) ⬆️
unittests1 55.53% <25.00%> (+8.64%) ⬆️
unittests2 34.34% <75.00%> (+6.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added the timeseries-engine Tracking tag for generic time-series engine work label Oct 7, 2024
@ankitsultana ankitsultana merged commit 7a9bc49 into apache:master Oct 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timeseries-engine Tracking tag for generic time-series engine work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants