Fix application qps quota stalls. #14859
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14859 +/- ##
============================================
+ Coverage 61.75% 63.75% +2.00%
- Complexity 207 1612 +1405
============================================
Files 2436 2708 +272
Lines 133233 151326 +18093
Branches 20636 23362 +2726
============================================
+ Hits 82274 96485 +14211
- Misses 44911 47594 +2683
- Partials 6048 7247 +1199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Do we have any existing tests that already exercise this path? Since we are changing the code on critical path, I suggest adding tests (if not there) |
| @@ -319,7 +319,7 @@ private void verifyQuotaUpdate(float quotaQps) { | |||
| } catch (IOException e) { | |||
| throw new RuntimeException(e); | |||
| } | |||
| }, 5000, "Failed to reflect query quota on rate limiter in 5s."); | |||
| }, 10000, "Failed to reflect query quota on rate limiter in 5s."); | |||
There was a problem hiding this comment.
Is this change expected?
There was a problem hiding this comment.
This change is not strictly necessary, so I'll revert it.
|
Quotas are tested mainly in HelixExternalViewBasedQueryQuotaManagerTest and QueryQuotaClusterIntegrationTest. I'll have a look at line coverage today. |
PR fixes #14852.