Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fins #1964

Closed
wants to merge 2 commits into from
Closed

Feature/fins #1964

wants to merge 2 commits into from

Conversation

rooterWzs
Copy link

I want to develop the Omron fins TCP driver. I have created an MSPEC file, but I was unable to generate Java driver code successfully. Do I need to manually create the plc4x \ plc4x \ plc4j \ drivers \ OmronFins directory?
Please correct and provide guidance

@hutcheb
Copy link
Contributor

hutcheb commented Jan 7, 2025

Yes you will need to manually create that section.

I would probably use the OpenProtocol driver to copy from, it seems to be one in which just the skeleton was written.

]

[type FinsFrame
[field FinsTCPHeader tcpHeader] // TCP 头部
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field keyword is valid here. It should probably be simple.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
I'll give it a try.

@hutcheb hutcheb marked this pull request as draft January 7, 2025 08:09
@ottlukas ottlukas added java Pull requests that update Java code feature labels Jan 7, 2025
@chrisdutz
Copy link
Contributor

Even if I stated multiple times that I'm no longer helping fix issues for free, I am more than willing to help you scratch your own itches (as long as the results go back into the PLC4X project) ... also currently have a lot of free time. So if you want, just reach out.

@sruehl
Copy link
Contributor

sruehl commented Jan 7, 2025

maybe try to rebase the branch instead of merging, makes the diff more readable (e.g. I don't get why it shows so much stuff in OPC-UA for example)

@rooterWzs
Copy link
Author

maybe try to rebase the branch instead of merging, makes the diff more readable (e.g. I don't get why it shows so much stuff in OPC-UA for example)

I I used 'git merge' for merging.I will redo the PR

@rooterWzs
Copy link
Author

Even if I stated multiple times that I'm no longer helping fix issues for free, I am more than willing to help you scratch your own itches (as long as the results go back into the PLC4X project) ... also currently have a lot of free time. So if you want, just reach out.

Okay, I'll contact you right away for some guidance

@rooterWzs rooterWzs closed this by deleting the head repository Jan 8, 2025
[simple uint 8 reserved] // 保留字段,通常为 0
[simple uint 8 flags] // 标志位,通常为 0
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments must be in English

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants