Adding comments #1971
Open
Adding comments #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruehl
reviewed
Jan 10, 2025
| @@ -520,6 +520,7 @@ static Object getTyped(Class<?> clazz, PlcReadResponse response, String sourceFi | |||
|
|
|||
| // Fallback | |||
| Object responseObject = response.getObject(sourceFieldName); | |||
| // Assuming getAll() returns a collection or related structure for validation | |||
There was a problem hiding this comment.
I don't understand the comment. Where does the getAll() come from?
There was a problem hiding this comment.
Sorry, I am just starting my open-source journey. I have no intention to disturb you, but I want to ensure I am doing things correctly. Could you please help me in my journey?
There was a problem hiding this comment.
First of all welcome the PLC4X Project :-). The question @sruehl has is why do you call the function "getAll()" is the function not called "getObject()" ? So where is the function getAll() come from? Where is it called? Other than beeing a little bit more precise and answer the question we follow "community over code" so every contribution, comment, question, testing etc. is welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding comments on PLcEntityInterceptor.java file in Fallback section as i am just starting my open source journey