refactor code that removes parts

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1917154 13f79535-47bb-0310-9956-ffa450edef68
apache · Apr 19, 2024 · ee525b6 · ee525b6
1 parent f335554
commit ee525b6
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 22 deletions.
diff --git a/poi-ooxml/src/main/java/org/apache/poi/ooxml/ReferenceRelationship.java b/poi-ooxml/src/main/java/org/apache/poi/ooxml/ReferenceRelationship.java
@@ -47,7 +47,7 @@ protected ReferenceRelationship(POIXMLDocumentPart container, PackageRelationshi
 
     protected ReferenceRelationship(POIXMLDocumentPart container, URI targetUri, boolean isExternal, String relationshipType, String id) {
         if (targetUri == null) {
-            throw new IllegalArgumentException("targetUri");
+            throw new NullPointerException("targetUri cannot be null");
         }
 
         this.container = container;

diff --git a/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java b/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
@@ -1025,7 +1025,6 @@ public void removePart(PackagePartName partName) {
         if (this.partList.containsKey(partName)) {
             this.partList.get(partName).setDeleted(true);
             this.removePartImpl(partName);
-            this.partList.remove(partName);
         } else {
             this.removePartImpl(partName);
         }
@@ -1551,8 +1550,16 @@ protected abstract PackagePart createPartImpl(PackagePartName partName,
      *
      * @param partName
      *            The URI of the part to delete.
+     * @throws IllegalArgumentException if the partName is null.
+     * @throws InvalidOperationException if the package is in read-only mode.
      */
-    protected abstract void removePartImpl(PackagePartName partName);
+    protected void removePartImpl(PackagePartName partName) {
+        if (partName == null) {
+            throw new IllegalArgumentException("partName cannot be null");
+        }
+        throwExceptionIfReadOnly();
+        this.partList.remove(partName);
+    }
 
     /**
      * Flush the package but not save.

diff --git a/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackageRelationship.java b/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackageRelationship.java
@@ -85,18 +85,20 @@ public final class PackageRelationship {
 
     /**
      * Constructor.
+     *
+     * @throws NullPointerException if inputs are null
      */
     public PackageRelationship(OPCPackage pkg, PackagePart sourcePart,
             URI targetUri, TargetMode targetMode, String relationshipType,
             String id) {
         if (pkg == null)
-            throw new IllegalArgumentException("pkg");
+            throw new NullPointerException("pkg cannot be null");
         if (targetUri == null)
-            throw new IllegalArgumentException("targetUri");
+            throw new NullPointerException("targetUri cannot be null");
         if (relationshipType == null)
-            throw new IllegalArgumentException("relationshipType");
+            throw new NullPointerException("relationshipType cannot be null");
         if (id == null)
-            throw new IllegalArgumentException("id");
+            throw new NullPointerException("id cannot be null");
 
         this.container = pkg;
         this.source = sourcePart;

diff --git a/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/ZipPackage.java b/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/ZipPackage.java
@@ -401,11 +401,11 @@ public int compareTo(EntryTriple o) {
     protected PackagePart createPartImpl(PackagePartName partName,
             String contentType, boolean loadRelationships) {
         if (contentType == null) {
-            throw new IllegalArgumentException("contentType");
+            throw new IllegalArgumentException("contentType cannot be null");
         }
 
         if (partName == null) {
-            throw new IllegalArgumentException("partName");
+            throw new IllegalArgumentException("partName cannot be null");
         }
 
         try {
@@ -424,19 +424,6 @@ protected PackagePart createPartImpl(PackagePartName partName,
         }
     }
 
-    /**
-     * Delete a part from the package
-     *
-     * @throws IllegalArgumentException
-     *             Throws if the part URI is null or invalid.
-     */
-    @Override
-    protected void removePartImpl(PackagePartName partName) {
-        if (partName == null) {
-            throw new IllegalArgumentException("partUri");
-        }
-    }
-
     /**
      * Flush the package. Do nothing.
      */