Skip to content

Commit

Permalink
Improve documentation and testing for PodMonitors (#317)
Browse files Browse the repository at this point in the history
* Imrpove documentation and testing for PodMonitors

* Fix missed references and a typo

### Motivation

Before upgrading to 3.0.0, we want to make sure the kube-prometheus-stack is well documented. 

### Modifications

* Update tests and examples to fully disable `PodMonitors` and the installation of the kube-prometheus-stack CRDs.

### Verifying this change

The current tests will cover these changes.
  • Loading branch information
michaeljmarshall authored Oct 20, 2022
1 parent 35090ec commit a963e73
Show file tree
Hide file tree
Showing 15 changed files with 384 additions and 4 deletions.
25 changes: 25 additions & 0 deletions .ci/clusters/values-bk-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

# disabled AntiAffinity
affinity:
Expand All @@ -31,9 +39,15 @@ components:

zookeeper:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

bookkeeper:
replicaCount: 3
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
diskUsageThreshold: "0.999"
diskUsageWarnThreshold: "0.999"
Expand All @@ -42,6 +56,9 @@ bookkeeper:

broker:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
## Enable `autoSkipNonRecoverableData` since bookkeeper is running
## without persistence
Expand All @@ -51,8 +68,16 @@ broker:
managedLedgerDefaultWriteQuorum: "1"
managedLedgerDefaultAckQuorum: "1"

autorecovery:
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

proxy:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

toolset:
useProxy: false
Expand Down
8 changes: 8 additions & 0 deletions .ci/clusters/values-broker-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

# disabled AntiAffinity
affinity:
Expand Down
25 changes: 25 additions & 0 deletions .ci/clusters/values-function.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

# disabled AntiAffinity
affinity:
Expand All @@ -31,9 +39,15 @@ components:

zookeeper:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

bookkeeper:
replicaCount: 3
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
diskUsageThreshold: "0.999"
diskUsageWarnThreshold: "0.999"
Expand All @@ -42,6 +56,9 @@ bookkeeper:

broker:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
## Enable `autoSkipNonRecoverableData` since bookkeeper is running
## without persistence
Expand All @@ -54,8 +71,16 @@ broker:
PF_functionInstanceMinResources_ram: "268435456"
PF_functionInstanceMinResources_disk: "268435456"

autorecovery:
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

proxy:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

toolset:
useProxy: false
25 changes: 25 additions & 0 deletions .ci/clusters/values-jwt-asymmetric.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

# disabled AntiAffinity
affinity:
Expand All @@ -31,9 +39,15 @@ components:

zookeeper:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

bookkeeper:
replicaCount: 2
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
diskUsageThreshold: "0.999"
diskUsageWarnThreshold: "0.999"
Expand All @@ -42,6 +56,9 @@ bookkeeper:

broker:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
## Enable `autoSkipNonRecoverableData` since bookkeeper is running
## without persistence
Expand All @@ -51,8 +68,16 @@ broker:
managedLedgerDefaultWriteQuorum: "1"
managedLedgerDefaultAckQuorum: "1"

autorecovery:
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

proxy:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

toolset:
useProxy: false
Expand Down
25 changes: 25 additions & 0 deletions .ci/clusters/values-jwt-symmetric.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

# disabled AntiAffinity
affinity:
Expand All @@ -31,9 +39,15 @@ components:

zookeeper:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

bookkeeper:
replicaCount: 3
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
diskUsageThreshold: "0.999"
diskUsageWarnThreshold: "0.999"
Expand All @@ -42,6 +56,9 @@ bookkeeper:

broker:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
## Enable `autoSkipNonRecoverableData` since bookkeeper is running
## without persistence
Expand All @@ -51,8 +68,16 @@ broker:
managedLedgerDefaultWriteQuorum: "1"
managedLedgerDefaultAckQuorum: "1"

autorecovery:
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

proxy:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

toolset:
useProxy: false
Expand Down
25 changes: 25 additions & 0 deletions .ci/clusters/values-local-pv.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

# disabled AntiAffinity
affinity:
Expand All @@ -31,9 +39,15 @@ components:

zookeeper:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

bookkeeper:
replicaCount: 3
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
diskUsageThreshold: "0.999"
diskUsageWarnThreshold: "0.999"
Expand All @@ -42,6 +56,9 @@ bookkeeper:

broker:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
## Enable `autoSkipNonRecoverableData` since bookkeeper is running
## without persistence
Expand All @@ -51,8 +68,16 @@ broker:
managedLedgerDefaultWriteQuorum: "1"
managedLedgerDefaultAckQuorum: "1"

autorecovery:
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

proxy:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

toolset:
useProxy: false
25 changes: 25 additions & 0 deletions .ci/clusters/values-pulsar-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@

kube-prometheus-stack:
enabled: false
prometheusOperator:
enabled: false
grafana:
enabled: false
alertmanager:
enabled: false
prometheus:
enabled: false

volumes:
persistence: false
Expand All @@ -34,9 +42,15 @@ components:

zookeeper:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

bookkeeper:
replicaCount: 3
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
diskUsageThreshold: "0.999"
diskUsageWarnThreshold: "0.999"
Expand All @@ -45,6 +59,9 @@ bookkeeper:

broker:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false
configData:
## Enable `autoSkipNonRecoverableData` since bookkeeper is running
## without persistence
Expand All @@ -54,8 +71,16 @@ broker:
managedLedgerDefaultWriteQuorum: "1"
managedLedgerDefaultAckQuorum: "1"

autorecovery:
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

proxy:
replicaCount: 1
# Disable pod monitor since we're disabling CRD installation
podMonitor:
enabled: false

toolset:
useProxy: false
Loading

0 comments on commit a963e73

Please sign in to comment.