Expose pulsar manager backend port #249
Conversation
There was a problem hiding this comment.
Thank you for your contribution @larmic! Sorry for the delayed review. Adding the service looks good to me, but I am not sure that we should change the existing service's name since it would be a breaking change.
| @@ -21,7 +21,7 @@ | |||
| apiVersion: v1 | |||
| kind: Service | |||
| metadata: | |||
| name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}" | |||
| name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}-frontend" | |||
There was a problem hiding this comment.
Changing this service name might break existing integrations. Can we leave it as is in this PR?
There was a problem hiding this comment.
@michaeljmarshall Hi, Michael, I fail to understand why this is a breaking change. It's an extension, not a change (apropos open-close-principle). If there is a reason why this would break, what else do you suggest we could submit in the next PR? Any strategy from the team?
|
Is their any update on this issue? This is still a problem in the main helm chart. |
|
Closing this as outdated. #457 fixes the issue. |
Fixes #
Motivation
To create a pulsar manager admin user, port 7750 must be available.
See also #229.
Modifications
I split the existing pulsar-manager-service.yaml into frontend and backend and made the backend configurable via a config parameter (pulsar_manager.serviceAdmin.enabled).
Verifying this change