Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple hostnames in ingress definitions #409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes
frankjkelly committed Nov 21, 2023
commit 78a4b7a8fe0ed62f32d9256bf12201bb29f6b7b7
3 changes: 1 addition & 2 deletions charts/pulsar/templates/dashboard-ingress-new.yaml
Original file line number Diff line number Diff line change
@@ -29,8 +29,7 @@
{{- $hostTLS := $host.tls | default dict -}}
{{- $hostTLSEnabled := $hostTLS.enabled | default true -}}
{{- if $hostTLSEnabled }}
{{- /* Generate secret name */ -}}
{{- $hostTLSSecretName := print "pulsar-" $.Values.dashboard.component "-" $hostTLS.secretName "-tls" -}}
{{- $hostTLSSecretName := $hostTLS.secretName -}}
{{- /* Default to an empty list */ -}}
{{- $tlsSecretHosts := list -}}
{{- /* Get the host list if we have seen the secret before */ -}}
5 changes: 2 additions & 3 deletions charts/pulsar/templates/proxy-ingress-new.yaml
Original file line number Diff line number Diff line change
@@ -29,8 +29,7 @@
{{- $hostTLS := $host.tls | default dict -}}
{{- $hostTLSEnabled := $hostTLS.enabled | default true -}}
{{- if $hostTLSEnabled }}
{{- /* Generate secret name */ -}}
{{- $hostTLSSecretName := print "pulsar-" $.Values.proxy.component "-" $hostTLS.secretName "-tls" -}}
{{- $hostTLSSecretName := $hostTLS.secretName -}}
{{- /* Default to an empty list */ -}}
{{- $tlsSecretHosts := list -}}
{{- /* Get the host list if we have seen the secret before */ -}}
@@ -92,7 +91,7 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.tls.proxy.enabled }}
{{- if .Values.proxy.ingress.tls.enabled }}
tls:
{{- range $tlsSecretName, $tlsHosts := $tlsData }}
- hosts:
5 changes: 2 additions & 3 deletions charts/pulsar/templates/pulsar-manager-ingress-new.yaml
Original file line number Diff line number Diff line change
@@ -29,8 +29,7 @@
{{- $hostTLS := $host.tls | default dict -}}
{{- $hostTLSEnabled := $hostTLS.enabled | default true -}}
{{- if $hostTLSEnabled }}
{{- /* Generate secret name */ -}}
{{- $hostTLSSecretName := print "pulsar-" $.Values.pulsar_manager.component "-" $hostTLS.secretName "-tls" -}}
{{- $hostTLSSecretName := $hostTLS.secretName -}}
{{- /* Default to an empty list */ -}}
{{- $tlsSecretHosts := list -}}
{{- /* Get the host list if we have seen the secret before */ -}}
@@ -87,7 +86,7 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.tls.pulsar_manager.enabled }}
{{- if .Values.pulsar_manager.ingress.tls.enabled }}
tls:
{{- range $tlsSecretName, $tlsHosts := $tlsData }}
- hosts: