Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of pull consumer #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaron-ai
Copy link
Member

@aaron-ai aaron-ai commented Apr 24, 2023

Fixes #500

@aaron-ai aaron-ai marked this pull request as draft April 24, 2023 07:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Attention: Patch coverage is 50.94131% with 443 lines in your changes missing coverage. Please review.

Project coverage is 46.26%. Comparing base (cea5343) to head (d169597).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
...mq/client/java/impl/consumer/PullConsumerImpl.java 61.09% 96 Missing and 18 partials ⚠️
...mq/client/java/misc/CustomLinkedBlockingQueue.java 2.72% 107 Missing ⚠️
...lient/java/impl/consumer/PullProcessQueueImpl.java 60.86% 65 Missing and 7 partials ⚠️
...cketmq/client/java/impl/consumer/ConsumerImpl.java 19.11% 55 Missing ⚠️
...t/java/impl/consumer/PullMessageQueuesScanner.java 60.71% 17 Missing and 5 partials ⚠️
...t/java/impl/consumer/PullSubscriptionSettings.java 29.41% 12 Missing ⚠️
...ketmq/client/java/misc/CacheBlockingListQueue.java 78.94% 6 Missing and 6 partials ⚠️
...e/rocketmq/client/java/impl/ClientManagerImpl.java 75.75% 8 Missing ⚠️
...q/client/java/impl/consumer/BatchMessageViews.java 0.00% 7 Missing ⚠️
...apache/rocketmq/client/java/rpc/RpcClientImpl.java 68.18% 7 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
+ Coverage     45.94%   46.26%   +0.31%     
- Complexity      667      770     +103     
============================================
  Files           207      217      +10     
  Lines         11503    12388     +885     
  Branches       2933     3045     +112     
============================================
+ Hits           5285     5731     +446     
- Misses         5988     6386     +398     
- Partials        230      271      +41     
Flag Coverage Δ
java 60.55% <50.94%> (-2.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaron-ai aaron-ai force-pushed the pull branch 7 times, most recently from 05bbd26 to 3da0034 Compare April 28, 2023 07:44
@aaron-ai aaron-ai force-pushed the pull branch 2 times, most recently from 8f8716c to 8ec4d48 Compare May 15, 2023 11:27
@aaron-ai aaron-ai force-pushed the pull branch 6 times, most recently from 70ad82e to 6900624 Compare June 14, 2023 06:11
@aaron-ai aaron-ai marked this pull request as ready for review June 14, 2023 06:13
@aaron-ai aaron-ai changed the title Implement pull consumer for java Initial implementation of pull consumer Jun 30, 2023
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale Pull request is stale label Jul 31, 2023
@aaron-ai aaron-ai added no stale This will never be considered stale and removed stale Pull request is stale labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale This will never be considered stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pull consumer for java
2 participants