-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust]support message type check on rust client #658
[rust]support message type check on rust client #658
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
=========================================
Coverage 46.69% 46.69%
Complexity 651 651
=========================================
Files 207 207
Lines 12120 12149 +29
Branches 3510 3539 +29
=========================================
+ Hits 5659 5673 +14
- Misses 6212 6225 +13
- Partials 249 251 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cargo-fmt failed, please fix it. |
|
…only Signed-off-by: Li Zhanhui <[email protected]>
@lizhanhui The new changes are way better. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Issue(s) This PR Fixes
Fixes #issue_id
Brief Description
The rust client doesn't have feature of checking message type with topic type. This pull request is to implement it.
How Did You Test This Change?
I've modified test cases in producer.rs to ensure tests to pass. Those tests are quite sufficient to test this feature.