Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust]support message type check on rust client #658

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

glcrazier
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #issue_id

Brief Description

The rust client doesn't have feature of checking message type with topic type. This pull request is to implement it.

How Did You Test This Change?

I've modified test cases in producer.rs to ensure tests to pass. Those tests are quite sufficient to test this feature.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2d3cdf7) 46.69% compared to head (47bd80c) 46.69%.
Report is 2 commits behind head on master.

Files Patch % Lines
rust/src/producer.rs 58.33% 10 Missing ⚠️
rust/src/model/message.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #658   +/-   ##
=========================================
  Coverage     46.69%   46.69%           
  Complexity      651      651           
=========================================
  Files           207      207           
  Lines         12120    12149   +29     
  Branches       3510     3539   +29     
=========================================
+ Hits           5659     5673   +14     
- Misses         6212     6225   +13     
- Partials        249      251    +2     
Flag Coverage Δ
rust 79.31% <68.57%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhanhui
Copy link
Contributor

cargo-fmt failed, please fix it.

@glcrazier
Copy link
Contributor Author

cargo-fmt failed, please fix it.
@lizhanhui already did.

@glcrazier
Copy link
Contributor Author

@lizhanhui The new changes are way better. Thanks.

Copy link
Contributor Author

@glcrazier glcrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhanhui lizhanhui merged commit 65b70ed into apache:master Jan 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants