Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #928] Fix C++ simple consumer error code and close function #931

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Jan 22, 2025

Which Issue(s) This PR Fixes

Fixes #928

Brief Description

How Did You Test This Change?

fuyou001
fuyou001 previously approved these changes Jan 22, 2025
@lizhimins lizhimins force-pushed the fix-simple-consumer branch from 3e92fa6 to 61c9f00 Compare January 22, 2025 12:21
@lizhimins lizhimins changed the title [ISSUE #928] Fix C++ simple consumer and use a soft link to associate the proto files [ISSUE #928] Fix C++ simple consumer error code and close function Jan 22, 2025
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 55e7dd2 into apache:master Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix some cpp client bug
2 participants