Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-commit hook pyupgrade to auto upgrade Python syntax #1638

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbampton
Copy link
Member

"A tool (and pre-commit hook) to automatically upgrade syntax for newer versions of the language."

https://github.com/asottile/pyupgrade

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No

What changes were proposed in this PR?

Added another check/test to our pre-commit framework.

How was this patch tested?

Ran locally: pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

"A tool (and pre-commit hook) to automatically upgrade syntax for newer versions of the language."

https://github.com/asottile/pyupgrade
@jbampton jbampton force-pushed the add-pre-commit-hook-pyupgrade branch from a0392b0 to c853c65 Compare October 13, 2024 16:30
@jbampton jbampton marked this pull request as ready for review October 13, 2024 17:16
@jbampton jbampton requested a review from jiayuasu as a code owner October 13, 2024 17:16
hooks:
- id: pyupgrade
args: [--py36-plus]
exclude: ^python/sedona/sql/dataframe_api\.py$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this excluded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jiayuasu I remember this file was causing problems when formatting.

I will review this again and report back. Thanks

@jbampton jbampton self-assigned this Oct 29, 2024
@jbampton jbampton marked this pull request as draft November 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants