Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MetaDataRefreshEngine.DDL_STATEMENT_CLASSES #34451

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Remove MetaDataRefreshEngine.DDL_STATEMENT_CLASSES #34451

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51efe0b
Remove MetaDataRefreshEngine.DDL_STATEMENT_CLASSES
terrymanu Jan 23, 2025
2cb1e2b
Remove MetaDataRefreshEngine.DDL_STATEMENT_CLASSES
terrymanu Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions ...ava/org/apache/shardingsphere/mode/metadata/refresher/metadata/MetaDataRefreshEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,8 @@
import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import org.apache.shardingsphere.mode.metadata.refresher.metadata.federation.FederationMetaDataRefresher;
import org.apache.shardingsphere.mode.persist.service.MetaDataManagerPersistService;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.AlterIndexStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.AlterSchemaStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.AlterTableStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.AlterViewStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.CreateIndexStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.CreateSchemaStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.CreateTableStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.CreateViewStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DDLStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropIndexStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropSchemaStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropTableStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropViewStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.RenameTableStatement;

import java.sql.SQLException;
import java.util.Arrays;
import java.util.Collection;
import java.util.Objects;
import java.util.Optional;
Expand All @@ -57,10 +42,6 @@
@RequiredArgsConstructor
public final class MetaDataRefreshEngine {

private static final Collection<Class<? extends DDLStatement>> DDL_STATEMENT_CLASSES = Arrays.asList(CreateTableStatement.class, AlterTableStatement.class, DropTableStatement.class,
CreateViewStatement.class, AlterViewStatement.class, DropViewStatement.class, CreateIndexStatement.class, AlterIndexStatement.class, DropIndexStatement.class, CreateSchemaStatement.class,
AlterSchemaStatement.class, DropSchemaStatement.class, RenameTableStatement.class);

private final MetaDataManagerPersistService metaDataManagerPersistService;

private final ShardingSphereDatabase database;
Expand All @@ -75,7 +56,7 @@ public final class MetaDataRefreshEngine {
*/
public boolean isNeedRefreshMetaData(final SQLStatementContext sqlStatementContext) {
Class<?> sqlStatementClass = sqlStatementContext.getSqlStatement().getClass().getSuperclass();
return DDL_STATEMENT_CLASSES.contains(sqlStatementClass);
return TypedSPILoader.findService(MetaDataRefresher.class, sqlStatementClass).isPresent();
}

/**
Expand All @@ -87,9 +68,6 @@ public boolean isNeedRefreshMetaData(final SQLStatementContext sqlStatementConte
*/
@SuppressWarnings({"unchecked", "rawtypes"})
public void refresh(final SQLStatementContext sqlStatementContext, final Collection<RouteUnit> routeUnits) throws SQLException {
if (!isNeedRefreshMetaData(sqlStatementContext)) {
return;
}
Class<?> sqlStatementClass = sqlStatementContext.getSqlStatement().getClass().getSuperclass();
Optional<MetaDataRefresher> metaDataRefresher = TypedSPILoader.findService(MetaDataRefresher.class, sqlStatementClass);
if (!metaDataRefresher.isPresent()) {
Expand Down
Loading