BanyanDB: Add installation check for storageOnly = true columns.
#12928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary. Those are records, not metrics. * Fix, move `Service`, `Instance`, `Endpoint` and `Process` relations out of `index-mode`, as they are time series.
wu-sheng
added
backend
wu-sheng
commented
Jan 4, 2025
Comment on lines
+182
to
+194
| List<String> storageOnlyTags | ||
| = tagsAndFields.tags.stream() | ||
| // filter out index tags | ||
| .filter(tagMetadata -> !tagMetadata.isIndex()) | ||
| // filter out seriesID tags | ||
| .filter(tagMetadata -> !seriesIDColumns.contains(tagMetadata.getTagSpec().getName())) | ||
| .map(tagMetadata -> tagMetadata.getTagSpec().getName()) | ||
| .collect(Collectors.toList()); | ||
| if (!storageOnlyTags.isEmpty()) { | ||
| throw new StorageException(model.getName() + ":" | ||
| + "storage only tags(" + storageOnlyTags + ") are not recommended in measure model, " | ||
| + "please change the entity to index mode or use field(@BanyanDB.MeasureField) instead"); | ||
| } |
There was a problem hiding this comment.
This part is the new logic. If there are storage-only tags exist in the installation stage, an exception will be thrown out.
|
Closing this PR, we can't do this. In the topology query, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.storageOnly = truecolumns. All columns should be@BanyanDB.MeasureFieldorin the index mode entity. Tags are for indexing columns and series IDs only.
@BanyanDB.IndexModefrom TopN implementation, as it's not necessary. Those are records, not metrics.Service,Instance,EndpointandProcessrelations out ofindex-mode, as they are time series.@hanahmily @wankai123 I was trying to make all
storageOnly = truecolumns in measure as fields automatically without extra/explict annotation, but I noticed the value-column still needs that explicit annotation. So, I still keep it. WDYT?