Avoid datetime deprecations in releaseWizard.py #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.12 deprecates two popular datetime functions that are used throughout the Release Wizard, 'utcnow()' and 'utcfromtimestamp()', resulting in many distracting messages that make the other wizard output hard to read, e.g. ``` DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). ``` This commit updates our 'datetime' usage in accordance with the Python recommendations.
HoustonPutman
approved these changes
Jan 23, 2025
|
The releaseWizard requires at least Python 3.4 and the replacement functions ('now' and 'fromtimestamp') have been around at least that long, so this should be safe to merge in that respect at least. |
|
Nah, it's a good change. Thanks for doing the housekeeping! |
janhoy
approved these changes
Jan 23, 2025
gerlowskija
deleted the
update-wizard-to-avoid-datetime-deprecation-warnings
branch
gerlowskija
added a commit
that referenced
this pull request
Jan 24, 2025
Python 3.12 deprecates two popular datetime functions that are used throughout the Release Wizard, 'utcnow()' and 'utcfromtimestamp()', resulting in many distracting messages that make the other wizard output hard to read, e.g. ``` DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). ``` This commit updates our 'datetime' usage in accordance with the Python recommendations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 deprecates two popular datetime functions that are used throughout the Release Wizard, 'utcnow()' and 'utcfromtimestamp()', resulting in many distracting messages that make the other wizard output hard to read, e.g.
This commit updates our 'datetime' usage in accordance with the Python recommendations.