Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP JDK 19 #1506

Closed
wants to merge 1 commit into from
Closed

WIP JDK 19 #1506

wants to merge 1 commit into from

Conversation

risdenk
Copy link
Contributor

@risdenk risdenk commented Mar 29, 2023

@risdenk risdenk self-assigned this Mar 29, 2023
@HoustonPutman
Copy link
Contributor

Why JDK19/20 over JDK 17?

@risdenk
Copy link
Contributor Author

risdenk commented Mar 30, 2023

Mostly just testing it out to see if it works. I know there are some float issues with JDK 19 and errorprone - https://issues.apache.org/jira/browse/SOLR-16431 you can see it in the test above:

> Task :solr:core:forbiddenApisMain
/home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/legacy/TestLegacyNumericUtils.java:269: warning: [FloatingPointLiteralPrecision] Floating point literal loses precision

          -9.9999999E+14f,
           ^
    (see https://errorprone.info/bugpattern/FloatingPointLiteralPrecision)
  Did you mean '-1.0E+15f,'?
/home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/legacy/TestLegacyNumericUtils.java:278: warning: [FloatingPointLiteralPrecision] Floating point literal loses precision
          9.9999999E+14f,
          ^
    (see https://errorprone.info/bugpattern/FloatingPointLiteralPrecision)
  Did you mean '1.0E+15f,'?
error: warnings found and -Werror specified

so not excluding JDK 17 by any means was just curious

@risdenk
Copy link
Contributor Author

risdenk commented Oct 30, 2024

Closing since main is on jdk 21 now

@risdenk risdenk closed this Oct 30, 2024
@risdenk risdenk deleted the jdk19 branch October 30, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants