Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17039: Entropy calculation fails in Docker due to missing 'bc' cmd #2023

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Oct 18, 2023

@janhoy janhoy requested review from epugh and HoustonPutman October 18, 2023 14:01
@HoustonPutman
Copy link
Contributor

Huh very cool, I learn more about bash every day!

@janhoy
Copy link
Contributor Author

janhoy commented Oct 18, 2023

Huh very cool, I learn more about bash every day!

And I learnt it from ChatGPT by giving it the old if statement and asking it to get rid of "bc" :-) I could of course also have used a plain if [[ $ratio -lt 25 ]] but I think the double parens were nice

@janhoy janhoy merged commit 5a9f914 into apache:main Oct 18, 2023
4 checks passed
janhoy added a commit that referenced this pull request Oct 18, 2023
janhoy added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants