-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17149: Fix backup/restore for large collections. #2243
Conversation
Hi @psalagnac - this LGTM, generally. The one thing missing IMO is some modifications to
If you're willing to accept my test changes, could you take a look at your branch settings and let me know when they're updated? Or alternatively, if you'd rather make the changes yourself, that's fine too. |
@gerlowskija Not sure why you got denied. I already checked the "Allow edits and access to secrets by maintainers" box. Can this be because of branch name case? ( |
Gah - that must've been it! Thanks for catching my mistake. I've pushed my test-changes, and run 'test'+'check' locally. So I'll merge and backport. Thanks for the quick fix @psalagnac ! |
Thanks for the test. Looks good to me. |
9.4 introduced a new executor used for "expensive" operations, that relied on a bounded queue. This caused backup operations to fail on collections large enough to hit this queue capacity. This commit fixes this problem by making the executor queue unbounded. --------- Co-authored-by: Pierre Salagnac <[email protected]> Co-authored-by: Jason Gerlowski <[email protected]>
9.4 introduced a new executor used for "expensive" operations, that relied on a bounded queue. This caused backup operations to fail on collections large enough to hit this queue capacity. This commit fixes this problem by making the executor queue unbounded. --------- Co-authored-by: Pierre Salagnac <[email protected]> Co-authored-by: Jason Gerlowski <[email protected]>
* main: Add bugfix version 8.11.3 Add 8.11.3 release to DOAP RDF file SOLR-16858: KnnQParser's "Pre-Filtering" behavior is now controlable via local params (closes apache#2157) SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 (apache#2240) dev-docs + help: try-and-tweak 'Solr X Lucene' docs (apache#2223) SOLR-17152: Better alignment of Admin UI graph (apache#2249) SOLR-15960: Find unexported variables with compgen (apache#2250) fix a few typos in the Indexing Guide (apache#2245) SOLR-17149: Fix backup/restore for large collections. (apache#2243) SOLR-17146: Add DelegatingBackupRepository and alternative checksum verification (apache#2239) Revert "Revert "SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 2 (apache#2231)"" SOLR-17038: /admin/segments handler: Expose the term count (apache#2233)
https://issues.apache.org/jira/browse/SOLR-17149
Description
A regression was introduced with SOLR-16879 that makes backup/restore failing when there are more than 5 shards per node.
Solution
Replace the bounded queue for async core admin tasks by an unbounded one.
Tests
No unit tests added.
Manually checked we don't have any tasks rejected by the executor.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.