SOLR-17159: Untangle PostTool and SimplePostTool code #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to deal with the SimplePostTool and PostTool migr
github-actions
bot
added
documentation
…ogs! Digging into code, I think auto didn't need to be a user centric concern at all, it's inside the PostTool logic.
|
This was all fun, but not I see that it's going to be VERY hard to backport the improvements I've made in the Post tool to branch_9x.. So I'm going to undo the deletions, get that merged, and then open a new one... |
epugh
changed the title
github-actions
bot
removed
the
documentation
Lets not start mixing case on our long options either... solrUrl is the java form, it really should be solr-url in our shell scripts.
epugh
added a commit
that referenced
this pull request
Feb 19, 2024
* Copied unit tests from SimplePostToolTest to PostToolTest * add a --dry-run mode that simulates sending documents to Solr * Missed a few more places with -commit not needed post SOLR-17147 being completed * clean up our code base to have fewer warnings about code quality. * Update SolrCloudExampleTest to use the PostTool instead of simulating it's usage. * Make the long form of -url expliciting a --solr-update-url to be clear what it's for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17159
Description
This untangles the links between PostTool and SimplePostTool, and their corresponding unit tests.
Solution
I seperated the code dependencies so a delete can be done easier on just
mainwhile this is intedned to go tobranch_9x. I introduced a--dry-runcapability on PostTool that a user can play with that also let us simplify some of the code by removing some mock specific features.Tests
new tests, both unit and bats.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.