Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.apache.hadoop:* to v3.4.0 #2380

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Apr 1, 2024

This PR contains the following updates:

Package Type Update Change
org.apache.hadoop:hadoop-minikdc test minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-hdfs test minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-client-minicluster test minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-common dependencies minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-client-runtime dependencies minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-client-api dependencies minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-auth dependencies minor 3.3.6 -> 3.4.0
org.apache.hadoop:hadoop-annotations dependencies minor 3.3.6 -> 3.4.0

Configuration

📅 Schedule: Branch creation - "before 9am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@github-actions github-actions bot added the dependencies Dependency upgrades label Apr 1, 2024
@solrbot solrbot force-pushed the renovate/org.apache.hadoop branch from 390175a to a2d94f7 Compare April 10, 2024 12:53
@solrbot solrbot force-pushed the renovate/org.apache.hadoop branch from a2d94f7 to 02cc8c9 Compare May 9, 2024 01:22
@solrbot solrbot force-pushed the renovate/org.apache.hadoop branch from 02cc8c9 to 9a98eb3 Compare June 5, 2024 12:43
@solrbot solrbot force-pushed the renovate/org.apache.hadoop branch 2 times, most recently from d174dd6 to 145971b Compare July 18, 2024 00:53
@janhoy
Copy link
Contributor

janhoy commented Jul 18, 2024

Created a JIRA SOLR-17374 for this

There were two new jar requirements: jline and jsch. Looks like both are only test deps related to parsing user input and executing hadoop tasks over ssh, so I'll exclude them from the build. (1e6b480)

Java level changes:

  • New signature for ReplicaMap constructor, where I replace new ReplicaMap(new ReentrantReadWriteLock()) with new ReplicaMap(new DataSetLockManager()). (7948541)
  • Use IOUtils.cleanupWithLogger instead of deprecated IOUtils.cleanup (55f1dce)
  • Remove a new unused dependency org.slf4j:jcl-over-slf4j:2.0.13@jar (8dfcc64)

Very happy for some review on these changes.

@solrbot
Copy link
Collaborator Author

solrbot commented Jul 18, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Sep 18, 2024
@janhoy
Copy link
Contributor

janhoy commented Oct 17, 2024

I got no response on my review request :(

Went ahead and brought up to date with main. Will use CTR for this then..

@janhoy
Copy link
Contributor

janhoy commented Oct 17, 2024

Thanks @risdenk

@janhoy janhoy merged commit fef5f5d into apache:main Oct 17, 2024
3 checks passed
janhoy pushed a commit to janhoy/solr that referenced this pull request Oct 17, 2024
* Update org.apache.hadoop:* to v3.4.0
* Exclude jline and jsch
* Fix lock for ReplicaMap
* Use IOUtils.cleanupWithLogger insteaad of deprecated IOUtils.cleanup
* unusedDeclaredArtifacts org.slf4j:jcl-over-slf4j:2.0.13@jar

Co-authored-by: Jan Høydahl <[email protected]>

(cherry picked from commit fef5f5d)
iamsanjay pushed a commit to iamsanjay/solr that referenced this pull request Oct 18, 2024
* Update org.apache.hadoop:* to v3.4.0
* Exclude jline and jsch
* Fix lock for ReplicaMap
* Use IOUtils.cleanupWithLogger insteaad of deprecated IOUtils.cleanup
* unusedDeclaredArtifacts org.slf4j:jcl-over-slf4j:2.0.13@jar

Co-authored-by: Jan Høydahl <[email protected]>
janhoy pushed a commit to janhoy/solr that referenced this pull request Oct 23, 2024
* Update org.apache.hadoop:* to v3.4.0
* Exclude jline and jsch
* Fix lock for ReplicaMap
* Use IOUtils.cleanupWithLogger insteaad of deprecated IOUtils.cleanup
* unusedDeclaredArtifacts org.slf4j:jcl-over-slf4j:2.0.13@jar

Co-authored-by: Jan Høydahl <[email protected]>

(cherry picked from commit fef5f5d)
janhoy added a commit that referenced this pull request Oct 23, 2024
* Update org.apache.hadoop:* to v3.4.0
* Exclude jline and jsch
* Fix lock for ReplicaMap
* Use IOUtils.cleanupWithLogger insteaad of deprecated IOUtils.cleanup
* unusedDeclaredArtifacts org.slf4j:jcl-over-slf4j:2.0.13@jar

Co-authored-by: Jan Høydahl <[email protected]>

(cherry picked from commit fef5f5d)

Co-authored-by: Solr Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants