SOLR-17276 Scrape metrics at fixed rate in prometheus-exporter #2442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17276
Description
Metrics are not scraped by prometheus-exporter at a fixed rate because it uses
scheduleWithFixedDelay
API to schedule the scraping proces. Duration of scraping influences the actual rate.Solution
Make sure Solr metrics are scraped at fixed rate by using
scheduleAtFixedRate
API.Note: there will be no overlapping executions, because JavaDoc says: "If any execution of this task takes longer than its period, then subsequent executions may start late, but will not concurrently execute.".
Tests
None
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.