SOLR-17282: Update basic-authentication-plugin.adoc #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the pwd encode format, there missed a ')', and this confused me , so i added this: (Format: base64(sha256(sha256(salt+password))) base64(salt))
github-actions
bot
added
the
documentation
gspgsp
changed the title
epugh
approved these changes
May 8, 2024
epugh
pushed a commit
that referenced
this pull request
May 8, 2024
for the pwd encode format, there missed a ')', which is confusing.
|
Code failure in precommit is also present in main, and known issue.. Thank you for the fix! |
dsmiley
pushed a commit
to iamsanjay/solr
that referenced
this pull request
May 8, 2024
for the pwd encode format, there missed a ')', which is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17282
Description
for the pwd encode format, there missed a ')', and this confused me , so i added this: (Format: base64(sha256(sha256(salt+password))) base64(salt))
Solution
i added this: (Format: base64(sha256(sha256(salt+password))) base64(salt))
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.