Minor: Http2SolrClient cleanups #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
commented
May 9, 2024
| mrrv.request | ||
| .onRequestQueued(asyncTracker.queuedListener) | ||
| .onComplete(asyncTracker.completeListener) | ||
| .send( | ||
| new InputStreamResponseListener() { | ||
| // MDC snapshot from requestAsync's thread | ||
| MDCCopyHelper mdcCopyHelper = new MDCCopyHelper(); |
There was a problem hiding this comment.
just reducing the scope of this var
| @@ -629,12 +624,6 @@ private static class MakeRequestReturnValue { | |||
| } | |||
| } | |||
|
|
|||
| private Request makeRequestAndSend( | |||
There was a problem hiding this comment.
used to be longer but after recent changes, it's pointless; inlining is clear
| @@ -438,13 +435,14 @@ public CompletableFuture<NamedList<Object>> requestAsync( | |||
| future.completeExceptionally(e); | |||
| return future; | |||
| } | |||
| final ResponseParser parser = | |||
| solrRequest.getResponseParser() == null ? this.parser : solrRequest.getResponseParser(); | |||
There was a problem hiding this comment.
not used; the parser is used but is considered elsewhere
|
I'll merge this in a couple days if I don't hear anything back. |
dsmiley
added a commit
that referenced
this pull request
May 23, 2024
pure refactoring (cherry picked from commit 0827de2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few small matters; no material changes.