SOLR-16396: Convert v2 configset APIs to JAX-RS #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert v2 configset APIs to JAX-RS
Also makes slight tweaks to line APIs up with the more REST-ful design
chosen for other v2 APIs.
- 'clone' (i.e. 'create-from-existing') is not available at `POST
/api/configsets {...}`
- 'delete' is now available at `DELETE /api/configsets/csName`
- 'list' is now available at `GET /api/configsets`
github-actions
bot
added
documentation
|
Still needed here: CHANGES.txt, ensure tests pass. |
gerlowskija
added a commit
that referenced
this pull request
Jan 3, 2025
Convert v2 configset APIs to JAX-RS. Naturally this adds the APIs to
Solr's growing v2 OAS, and ensures the APIs are included in code-gen
artifacts.
Also makes slight tweaks to line APIs up with the more REST-ful design
chosen for other v2 APIs.
- 'clone' (i.e. 'create-from-existing') is now available at `POST
/api/configsets {...}`
- 'delete' is now available at `DELETE /api/configsets/csName`
- 'list' is now available at `GET /api/configsets`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16396
Description
Solr's v2 API supports configset operations, but the underlying implementation of these uses the legacy API framework.
Solution
This PR moves create/clone configset, delete configset, upload configset, and upload configset file to be implemented using the JAX-RS framework. This ensures that the APIs are covered by our v2 API OAS, and includes them in all code-generation done using the OAS.
It also makes slight tweaks to the appearance of these APIs to help them fit in a bit more with the current API design. In particular:
/api/configsetspathPOST /api/configsets {"name": "newCS", "baseConfigSet": "existingCS", "properties": {...}}Tests
Modified tests in TestConfigSetsAPI. Otherwise existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.