Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17617: Add missing Inject to CollectionProperty and InstallCoreData #3023

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colvinco
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17617

Description

Add missing @Inject annotations.

Tests

TODO: add a smoke test for all v2 APIs

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@gerlowskija
Copy link
Contributor

@colvinco asked the following in a dev-thread related to this PR:

I've not really looked at the BATS tests before. [...] I take it I can just run
curl to poke each API. So they should be quick enough to write when I
get back to this next week. Is that the best option then? Or should I use
the RestTestBase and go that route instead?

My two cents are that we'd be better sticking to a Java-based test here. BATS tests give you, in some senses, a bit more fidelity than a JUnit test since they're testing the same tgz or zip distribution that an end-user downloads, but that comes at a pretty steep cost: they're much much slower to run, can't be parallelized, aren't cross-platform, etc.

So my suggestion would be to write in Java unless you run into a reason to do otherwise.

That said - if you like the simplicity of BATS or think the extra fidelity is worth it, I'm OK with that too. This'll be a big boost to our v2 test coverage, so it'll be a huge win whichever approach you take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants