[SPARK-50773][Core] Disable structured logging by default #49421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
requested review from
grundprinzip,
HeartSaVioR,
LuciferYang,
mridulm,
cloud-fan,
HyukjinKwon,
yaooqinn,
dongjoon-hyun,
panbingkun and
allisonwang-db
gengliangwang
changed the title
dongjoon-hyun
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Well, the link of the PR description was a discussion thread, not a vote.
I believe we need an official vote in order to overthrow your existing vote (24+1s including 13 binding +1s), @gengliangwang .
https://lists.apache.org/thread/kc4mcxoxz4gw0qh2v6rxxf0lyjlx9k5p ([VOTE][RESULT] SPIP: Structured Logging Framework for Apache Spark)
The vote passes with 24+1s (13 binding +1s).
For the record, I don't think new vote will fail. Since the existing plain text is also the traditional way, I believe new vote will pass. I'm just saying the discussion thread is insufficient in this case.
HyukjinKwon
approved these changes
Jan 9, 2025
|
Oh, yeah +1 for vote. |
|
@dongjoon-hyun sure, let's start a vote. |
|
Thank you, @HyukjinKwon and @gengliangwang . |
LuciferYang
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR restores the default Spark logging format to plain text instead of JSON.
After changes, compared to Spark 3.x releases, uses can optionally enable structured logging by setting configuration
spark.log.structuredLogging.enabledtotrue(default isfalse). For additional customization, users can copylog4j2-json-layout.properties.templatetoconf/log4j2.propertiesand adjust as needed.Why are the changes needed?
After discussions on the dev mailing list, Spark developers decided to revert to the previous plain text logging format for two main reasons:
Does this PR introduce any user-facing change?
No, Spark 4.0 has not yet been released.
How was this patch tested?
Existing tests. Also, manually tested on enable/disable the configuration
spark.log.structuredLogging.enabled, as well as verified the logging behavior with different log4j2 templates.Was this patch authored or co-authored using generative AI tooling?
No