[SPARK-50768][SQL][CORE][FOLLOW-UP] Apply TaskContext.createResourceUninterruptibly() to risky resource creations #49508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jan 15, 2025
cloud-fan
approved these changes
Jan 16, 2025
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 16, 2025
…ninterruptibly() to risky resource creations ### What changes were proposed in this pull request? This is a follow-up PR for #49413. This PR intends to apply `TaskContext.createResourceUninterruptibly()` to the resource creation where it has the potential risk of resource leak in the case of task cancellation. ### Why are the changes needed? Avoid resource leak. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? n/a ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49508 from Ngone51/SPARK-50768-followup. Authored-by: Yi Wu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9b32334) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to master/4.0. Thank you, @Ngone51 and all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR for #49413. This PR intends to apply
TaskContext.createResourceUninterruptibly()to the resource creation where it has the potential risk of resource leak in the case of task cancellation.Why are the changes needed?
Avoid resource leak.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
n/a
Was this patch authored or co-authored using generative AI tooling?
No.