[STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase @LoggingResearch |
rzo1
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Exception needs to be removed from throws
|
@LoggingResearch any updates on this? |
|
IDE reports, that this exception isn't thrown at the place the catch block was added. I am closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include:
Adding a separate catch block for InterruptedException that is thrown by the close() method of the AsyncLocalizer class.
Logging the InterruptedException separately to ensure that the exception type and message are correctly recorded in the logs.
The motivation behind this change is to properly handle the scenario where the close() method of AsyncLocalizer is interrupted, which is a situation that was not specifically addressed in the original code. By catching and logging the InterruptedException separately, we can provide more specific information in the logs when such an event occurs.
How was the change tested
Built storm-server. Validated logging on dev supervisor.