[STORM-4003] add missing jakarta.xml.bind dependency to storm-kafka-monitor #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnioche
changed the title
rzo1
approved these changes
Nov 15, 2023
|
i see that there's an integration error , but I don't understand how it could relate to my PR. Any idea ? |
|
Most likely flaky test (as it passes on 17,21). Retriggered. |
|
okay tests are passing now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When running Storm UI with Java 17 runtime, the lag of Kafka consumers is not visible in the topology view for the topologies which are consuming Kafka topics. Based on exceptions found in ui.log, this is because storm-kakfa-monitor is missing JAXB API.
How was the change tested
Using Storm 2.6.0 snapshot dated 2023/11/14, doing a copy of jakarta.xml.bind-api-2.3.2.jar from lib-worker/ to lib-tools/storm-kafka-monitor/ then restarting Storm UI process solves the problem.