StormExecutor: adding an unit test to changes introduced in STORM-3693 #3834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
StormExecutor: adding an unit test to check if the RotatingMap'
rotate
is called only once when timing out tuples.StormExecutor
requires a considerable effort to mock and thepending
map (which is RotatingMap) is an internal attribute. JUnit's reflection was used to mock the RotationMap and verify how many timesrotate
was called.This test is far from optimal and I'm not a fan of using reflection, but will make it easier to detect regressions.
The test should be refactored in the future.
Additionally, refactored the changes introduced in #3828:
boolean isSpout = this instanceof SpoutExecutor;
should not be in Executor. A parent class should not have references to subclassesHow was the change tested
mvn clean install
. All tests are passing.