Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] add maven-scalastyle-plugin #3842

Merged
merged 6 commits into from
Jul 7, 2024
Merged

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Jul 7, 2024

[Improve] add maven-scalastyle-plugin

What changes were proposed in this pull request

  1. add maven-scalastyle-plugin
  2. unify scala code style

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@wolfboys
Copy link
Member Author

wolfboys commented Jul 7, 2024

cc @SbloodyS PTAL, thx

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wangsizhu0504 wangsizhu0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 4ef83ae into apache:dev Jul 7, 2024
34 of 35 checks passed
@wolfboys wolfboys deleted the scala-style branch July 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants