-
Notifications
You must be signed in to change notification settings - Fork 481
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SYSTEMDS-3765] Reproducible test case for the need of time() hoisting
- Loading branch information
Showing
2 changed files
with
97 additions
and
0 deletions.
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
src/test/java/org/apache/sysds/test/functions/rewrite/RewriteHoistingTimeTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.sysds.test.functions.rewrite; | ||
|
||
import org.junit.Test; | ||
import org.apache.sysds.common.Types.ExecMode; | ||
import org.apache.sysds.common.Types.ExecType; | ||
import org.apache.sysds.test.AutomatedTestBase; | ||
import org.apache.sysds.test.TestConfiguration; | ||
import org.apache.sysds.test.TestUtils; | ||
|
||
public class RewriteHoistingTimeTest extends AutomatedTestBase | ||
{ | ||
private static final String TEST_NAME1 = "RewriteTimeHoisting"; | ||
|
||
private static final String TEST_DIR = "functions/rewrite/"; | ||
private static final String TEST_CLASS_DIR = TEST_DIR + RewriteHoistingTimeTest.class.getSimpleName() + "/"; | ||
|
||
private static final int rows = 1001; | ||
private static final int cols = 1002; | ||
|
||
@Override | ||
public void setUp() { | ||
TestUtils.clearAssertionInformation(); | ||
addTestConfiguration( TEST_NAME1, new TestConfiguration(TEST_CLASS_DIR, TEST_NAME1, new String[] {"R"}) ); | ||
} | ||
|
||
@Test | ||
public void testTimeHoisting() { | ||
test(TEST_NAME1, ExecType.CP); | ||
} | ||
|
||
private void test(String testname, ExecType et) | ||
{ | ||
ExecMode platformOld = setExecMode(et); | ||
|
||
try | ||
{ | ||
TestConfiguration config = getTestConfiguration(testname); | ||
loadTestConfiguration(config); | ||
|
||
String HOME = SCRIPT_DIR + TEST_DIR; | ||
fullDMLScriptName = HOME + testname + ".dml"; | ||
programArgs = new String[] { "-explain", "-args", | ||
String.valueOf(rows), String.valueOf(cols) }; | ||
|
||
//FIXME need to hoist time() out of expression similar to function calls | ||
runTest(true, false, null, -1); | ||
} | ||
finally { | ||
resetExecMode(platformOld); | ||
} | ||
} | ||
} |
26 changes: 26 additions & 0 deletions
26
src/test/scripts/functions/rewrite/RewriteTimeHoisting.dml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#------------------------------------------------------------- | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
# | ||
#------------------------------------------------------------- | ||
|
||
t1 = time(); | ||
X = rand(rows=$1, cols=$2); | ||
|
||
print("time = "+(time()-t1)/1e9+"s"+" "+sum(X)); | ||
|
742eec8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean?
is the time command executed before the sum?
742eec8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the second time command is executed before the rand operation which it supposed to measure. Currently, we split time() into a separate program block, but only if they bind directly to a variable. We had similar issues with functions, and hoist them out of these expressions into artificial program blocks where they appear in the original program.