Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] cleanups and optimizations to CLA MM primitives #2210

Closed
wants to merge 1 commit into from

Conversation

Baunsgaard
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 30 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (ece172a) to head (88fe829).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../sysds/runtime/compress/lib/CLALibRightMultBy.java 71.83% 15 Missing and 5 partials ⚠️
...ache/sysds/runtime/compress/lib/CLALibMMChain.java 77.14% 7 Missing and 1 partial ⚠️
...e/sysds/runtime/compress/colgroup/ColGroupDDC.java 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2210   +/-   ##
=========================================
  Coverage     72.39%   72.39%           
- Complexity    45333    45351   +18     
=========================================
  Files          1467     1467           
  Lines        170536   170602   +66     
  Branches      33247    33257   +10     
=========================================
+ Hits         123454   123510   +56     
- Misses        37691    37703   +12     
+ Partials       9391     9389    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit include specialized decompressing MM for DDC with identity matrix dictionaries.
@Baunsgaard Baunsgaard force-pushed the CLALibMMOptimizations branch from 659f819 to 88fe829 Compare February 3, 2025 15:27
@Baunsgaard Baunsgaard closed this in a6d8bc0 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant