-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYSTEMDS-3830] Add join operator to Scuro #2220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
============================================
- Coverage 72.38% 72.38% -0.01%
- Complexity 45381 45384 +3
============================================
Files 1468 1468
Lines 170802 170802
Branches 33306 33306
============================================
- Hits 123634 123628 -6
- Misses 37762 37767 +5
- Partials 9406 9407 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
From a systems perspective we could separate the changes to src/main/python/systemds/__init__.py
into another commit.
@Baunsgaard, sounds good. I removed the changes to the init.py and will create another commit with the version changes. |
Great, I have now merged it. |
This patch adds a new join operator to scuro. The join operation takes two modalities as well as a join condition as input and joins the two modalities on their common dimension (temporal for now). This includes two new modalities and the ability to apply new representations on top of a joined modality. In the future the join operator will also serve as a simple alignment operator by joining two modalities by a given offset.