Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Dependency tasks enable via Log4j #2222

Closed

Conversation

Baunsgaard
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (bea9c96) to head (df36b88).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2222      +/-   ##
============================================
+ Coverage     72.45%   72.47%   +0.01%     
- Complexity    45434    45447      +13     
============================================
  Files          1469     1469              
  Lines        170861   170869       +8     
  Branches      33307    33311       +4     
============================================
+ Hits         123799   123837      +38     
+ Misses        37661    37630      -31     
- Partials       9401     9402       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baunsgaard
Copy link
Contributor Author

@phaniarnab , Is this change okay?
I wanted to see the parallelization graph of transform encode, however, I did wanted it without recompiling the system.

We can lower it to LOG.trace level perhaps.

@phaniarnab
Copy link
Contributor

@phaniarnab , Is this change okay? I wanted to see the parallelization graph of transform encode, however, I did wanted it without recompiling the system.

We can lower it to LOG.trace level perhaps.

Did you try enabling the debug flag, that prints the task graph on the console?

@phaniarnab
Copy link
Contributor

I see now what you wanted. Changes look fine.
Can you perhaps post the output here so that we can see it looks? @Baunsgaard

@Baunsgaard
Copy link
Contributor Author

It looks something like:

EXPlAIN (TASK-GRAPH):ColumnRecodeBuildTask<ColId: 1><Prio: 5><Waiting: 2>
--ColumnCompositeUpdateDCTask<ColId: 1><Prio: 5><Waiting: 4>
--AllocMetaTask<Prio: 0><Waiting: 1>
----UpdateOutputColTask<Prio: 0><Waiting: 1>
----ColumnMetaDataTask<ColId: 1><Prio: 0><Waiting: 0>
----InitOutputMatrixTask<Prio: 0><Waiting: 1>
------ApplyTasksWrapperTask<ColId: 1>

for a small transform encode : "{dummycode:[C1]}"

@phaniarnab
Copy link
Contributor

It looks something like:

EXPlAIN (TASK-GRAPH):ColumnRecodeBuildTask<ColId: 1><Prio: 5><Waiting: 2>
--ColumnCompositeUpdateDCTask<ColId: 1><Prio: 5><Waiting: 4>
--AllocMetaTask<Prio: 0><Waiting: 1>
----UpdateOutputColTask<Prio: 0><Waiting: 1>
----ColumnMetaDataTask<ColId: 1><Prio: 0><Waiting: 0>
----InitOutputMatrixTask<Prio: 0><Waiting: 1>
------ApplyTasksWrapperTask<ColId: 1>

for a small transform encode : "{dummycode:[C1]}"

Looks good. Merge it 💯

@Baunsgaard Baunsgaard closed this in b85d1b4 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants