TINKERPOP-3124 Added custom MessageSizeEstimator to cover Frame #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhuuu
reviewed
Jan 7, 2025
| * `sessions` - The number of sessions open at the time the metric was last measured. For the `UnifiedChannelizer`, each | ||
| request creates a "session", even a so-called "sessionless request", which is basically a session that will only | ||
| execute within the context of that single request. | ||
| * `channels.paused` - The current number of open channels (HTTP and Websocket) that are have their writes to buffer |
There was a problem hiding this comment.
Suggested change
| * `channels.paused` - The current number of open channels (HTTP and Websocket) that are have their writes to buffer | |
| * `channels.paused` - The current number of open channels (HTTP and WebSocket) that have their writes to buffer |
kenhuuu
reviewed
Jan 7, 2025
| likelihood of the server hitting `OutOfMemoryExceptions` and other performance problems that may appear under certain | ||
| workloads and network conditions. | ||
|
|
||
| It is worth nothing that logging around the `writeBufferHighWaterMark` has been modified to include a bit more |
There was a problem hiding this comment.
Suggested change
| It is worth nothing that logging around the `writeBufferHighWaterMark` has been modified to include a bit more | |
| It is worth noting that logging around the `writeBufferHighWaterMark` has been modified to include a bit more |
|
VOTE +1 |
Improved logging around channel pauses. Added new metrics for Gremlin Server around channels and pauses. Added some extra capabilities to the java driver profiling tool.
spmallette
force-pushed
the
TINKERPOP-3124
branch
from
6f0133d to
d136e0f
Compare
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3124
Improved logging around channel pauses. Added new metrics for Gremlin Server around channels and pauses. Added some extra capabilities to the java driver profiling tool.
VOTE +1