Skip to content

Commit

Permalink
Rewrite comments to improve clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
YIHONG-JIN committed Dec 20, 2024
1 parent 8a06676 commit 339f013
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/iocore/net/UnixNetVConnection.cc
Original file line number Diff line number Diff line change
Expand Up @@ -574,11 +574,10 @@ UnixNetVConnection::net_read_io(NetHandler *nh)
return;
}

// We should only splice once to the pipe
// Linux splice() does not merge pipe buffer page so there is no guarantee that we can splice to pipe again
// without receiving EAGAIN from pipe even if data_in_pipe < pipe_capacity
// Disable read until consumer finish a successful splice from pipe to socket operation
// which means there are available pages in the pipe
// We should only splice once to the pipe until the pipe is cleared by consumer
// Linux splice() does not merge pipe buffer page so there is no guarantee that
// we can splice to pipe again without receiving EAGAIN from pipe even if data_in_pipe < pipe_capacity
// Disable read until consumer finish a successful splice from pipe to socket operation and the pipe is empty
read_disable(nh, this);
return;
}
Expand Down

0 comments on commit 339f013

Please sign in to comment.